Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add failing test for cache.modify problem #9439

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: add failing test for cache.modify problem #9439

wants to merge 1 commit into from

Conversation

Narretz
Copy link

@Narretz Narretz commented Feb 17, 2022

This PR contains two tests for a cache update behavior with watchQuery.

One uses cache.modify (and fails currently), the other uses cache.updateQuery (which works).

I think both should work.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@apollo-cla
Copy link

@Narretz: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@Narretz Narretz mentioned this pull request Feb 17, 2022
Open
@jpvajda jpvajda added 🏓 awaiting-contributor-response requires input from a contributor 🏓 awaiting-team-response requires input from the apollo team and removed 🏓 awaiting-contributor-response requires input from a contributor labels May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏓 awaiting-team-response requires input from the apollo team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Narretz @apollo-cla @jpvajda